Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| pid_file: str | Path | None = None, | ||
| state_dir: str | Path | None = None, | ||
| pid_file: Optional[str | Path] = None, | ||
| state_dir: Optional[str | Path] = None, |
There was a problem hiding this comment.
Inconsistent union type syntax breaks Python 3.8/3.9 compatibility
The PR inconsistently converts union types for compatibility. In these files, Optional[str | Path] is used, but the | union syntax requires Python 3.10+. The project's pyproject.toml declares requires-python = ">=3.8" with explicit support for Python 3.8 and 3.9. Other files in this same PR correctly use Optional[Union[str, Path]] (e.g., config/config.py). If get_type_hints() is called on these functions at runtime, it will fail on Python 3.8/3.9 with a TypeError.
Additional Locations (2)
| retention-days: 7 | ||
|
|
||
| - name: Trigger Read the Docs build | ||
| if: env.RTD_API_TOKEN != '' |
There was a problem hiding this comment.
Workflow condition checks wrong context, never triggers RTD build
The condition if: env.RTD_API_TOKEN != '' checks for an environment variable at the job level, but RTD_API_TOKEN is only defined within the step's own env: block (line 180). GitHub Actions evaluates if: conditions before the step runs, so env.RTD_API_TOKEN will always be empty/undefined. This means the "Trigger Read the Docs build" step will never execute, even when the secret is properly configured. The condition should use secrets.RTD_API_TOKEN != '' to check if the secret exists.
Additional Locations (1)
1 participant
…ments
Note
Modernizes CI/docs and broadens Python compatibility while adding small CLI capabilities.
Build Documentationworkflow triggers on push/PR; ensures reports before mkdocs; triggers Read the Docs via API; simplifies Bandit to a single JSON output; removes|| echofrom coverage step; adds compatibility linter to CI.|unions withOptional/Unionacrossccbt/cli,config,core,daemon, andconsensusfor Python 3.8 support; minor signature and annotation cleanups.--enable-v2,--disable-v2,--prefer-v2,--v2-only) todownload/magnet; minor safety/logging and progress API tweaks..gitignoreadditions (compatibility_tests/,lint_outputs/).Written by Cursor Bugbot for commit 31092da. This will update automatically on new commits. Configure here.